Skip to content

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Form Control #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HoussamLh wants to merge 11 commits into from
Closed

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Form Control #754

HoussamLh wants to merge 11 commits into from

Conversation

@HoussamLh
Copy link

@HoussamLh HoussamLh commented Sep 7, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR for cleaning my main branch and syn my fork and updating my branch.

Questions

Please, let me know if there is anything else went wrong?

@netlify
Copy link

netlify bot commented Sep 7, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit feba4ad
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68c02d90ed789c0008923c3b
😎 Deploy Preview https://deploy-preview-754--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 87 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@HoussamLh HoussamLh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2025
cjyuan
cjyuan reviewed Sep 7, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is Wireframe/style.css part of Form-Control exercise? If not, please keep the branch clea.

  • Lighthouse score is not yet 100.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 7, 2025
@HoussamLh
index.html
d809ce6 
- I cleaned my branch Feature/FormControl.
- Validate my code on the Html validator online.
@HoussamLh
style.css
feba4ad 
- Fix style.css that I've made changes by mistake.
- I took it easy just copie the content of file CSS from codeyourfuture repo and then paste it in my repo.
- I think this is the easiest way to fix this issue.
@HoussamLh HoussamLh closed this Sep 9, 2025
@HoussamLh HoussamLh reopened this Sep 9, 2025
@HoussamLh HoussamLh closed this Sep 9, 2025
@HoussamLh HoussamLh deleted the Feature/FormControl branch September 9, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HoussamLh @cjyuan